[openwrt/openwrt] base-files: fix off-by-one in counting seconds for factory reset

LEDE Commits lede-commits at lists.infradead.org
Wed Feb 28 23:05:01 PST 2018

rmilecki pushed a commit to openwrt/openwrt.git, branch master:

commit 2995d9dfee4cd5a24ff30d15ac9168c9fd443625
Author: Rafał Miłecki <rafal at milecki.pl>
AuthorDate: Tue Feb 27 16:44:25 2018 +0100

    base-files: fix off-by-one in counting seconds for factory reset
    There was a mismatch between indicating factory reset and code actually
    starting it. After 5 seconds status LED started blinking rapidly letting
    user know it's ready to release reset button. In practice button had to
    stay pressed for another second in order to relly start the process.
    Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
 package/base-files/files/etc/rc.button/reset | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/base-files/files/etc/rc.button/reset b/package/base-files/files/etc/rc.button/reset
index 4265767..2403122 100755
--- a/package/base-files/files/etc/rc.button/reset
+++ b/package/base-files/files/etc/rc.button/reset
@@ -20,7 +20,7 @@ released)
 		echo "REBOOT" > /dev/console
-	elif [ "$SEEN" -gt 5 -a -n "$OVERLAY" ]
+	elif [ "$SEEN" -ge 5 -a -n "$OVERLAY" ]
 		echo "FACTORY RESET" > /dev/console
 		jffs2reset -y && reboot &

More information about the lede-commits mailing list