[source] build: use if-then to avoid non-zero return codes in bin/ packaging code

LEDE Commits lede-commits at lists.infradead.org
Mon Jan 23 04:49:58 PST 2017


nbd pushed a commit to source.git, branch master:
https://git.lede-project.org/6699f58fdbfd74cd3206bd1bc3311e395204ba30

commit 6699f58fdbfd74cd3206bd1bc3311e395204ba30
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Mon Jan 23 13:40:15 2017 +0100

    build: use if-then to avoid non-zero return codes in bin/ packaging code
    
    Signed-off-by: Felix Fietkau <nbd at nbd.name>
---
 include/package-bin.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/package-bin.mk b/include/package-bin.mk
index 68f5831..4ae049a 100644
--- a/include/package-bin.mk
+++ b/include/package-bin.mk
@@ -29,10 +29,10 @@ ifeq ($(DUMP),)
     install-bin-$(1): $(PKG_BUILD_DIR)/.pkgdir/$(1).installed
 	rm -rf $(BIN_DIR)/$(1)
 	-rmdir $(PKG_BUILD_DIR)/.pkgdir/$(1) >/dev/null 2>/dev/null
-	[ -d $(PKG_BUILD_DIR)/.pkgdir/$(1) ] && { \
+	if [ -d $(PKG_BUILD_DIR)/.pkgdir/$(1) ]; then \
 		$(INSTALL_DIR) $(BIN_DIR)/$(1) && \
 		$(CP) $(PKG_BUILD_DIR)/.pkgdir/$(1)/. $(BIN_DIR)/$(1)/; \
-	}
+	fi
 
     clean-$(1):
 	  rm -rf $(BIN_DIR)/$(1)



More information about the lede-commits mailing list