[source] base-files: fix message of initscript wrapper
LEDE Commits
lede-commits at lists.infradead.org
Mon Jan 2 07:48:06 PST 2017
jow pushed a commit to source.git, branch master:
https://git.lede-project.org/8496659eb464928a645025a55a7cd487e83199cb
commit 8496659eb464928a645025a55a7cd487e83199cb
Author: Alberto Bursi <alberto.bursi at outlook.it>
AuthorDate: Sun Jan 1 17:24:18 2017 +0100
base-files: fix message of initscript wrapper
currently (after blogic's edit to my commit) it prints like this:
root at lede:/# service aa
aa does not exist. the following services are available :adblock dnsmasq gpio_switch rpcd system
boot done led sqm uhttpd
crelay dropbear log sysctl umount
cron firewall network sysfixtime urandom_seed
ddns fstab odhcpd sysntpd
which looks pretty bad, and is even worse if someone writes only "service" without arguments, as it will print " does not exist. " which is confusing.
with this commit it looks like this:
root at lede:/# service
service "" not found, the following services are available:
adblock dnsmasq gpio_switch rpcd system
boot done led sqm uhttpd
crelay dropbear log sysctl umount
cron firewall network sysfixtime urandom_seed
ddns fstab odhcpd sysntpd
Yes there is some play with " and ', it is to display "name" or just "" if no service name is entered (like in the example).
Signed-off-by: Alberto Bursi <alberto.bursi at outlook.it>
---
package/base-files/files/etc/profile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/base-files/files/etc/profile b/package/base-files/files/etc/profile
index bb69ffb..3eda09b 100644
--- a/package/base-files/files/etc/profile
+++ b/package/base-files/files/etc/profile
@@ -44,7 +44,7 @@ fi
service() {
[ -f "/etc/init.d/$1" ] || {
- echo -n "$1 does not exist. the following services are available :"
+ echo "service "'"'"$1"'"'" not found, the following services are available:"
ls "/etc/init.d"
return 1
}
More information about the lede-commits
mailing list