[source] arc770: only calculate entry point address when necessary

LEDE Commits lede-commits at lists.infradead.org
Tue Feb 21 07:10:41 PST 2017


nbd pushed a commit to source.git, branch master:
https://git.lede-project.org/f77a1aac0b7d56085f5d169adac9b29384c69528

commit f77a1aac0b7d56085f5d169adac9b29384c69528
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Thu Feb 16 07:50:55 2017 +0100

    arc770: only calculate entry point address when necessary
    
    $(eval) runs even during prereq check, which can cause bogus error
    messages
    
    Signed-off-by: Felix Fietkau <nbd at nbd.name>
---
 target/linux/arc770/image/Makefile | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/target/linux/arc770/image/Makefile b/target/linux/arc770/image/Makefile
index f52f840..2607578 100644
--- a/target/linux/arc770/image/Makefile
+++ b/target/linux/arc770/image/Makefile
@@ -10,9 +10,7 @@ include $(INCLUDE_DIR)/image.mk
 # On ARC initramfs is put before entry point and so entry point moves
 # in memory from build to built. Thus we need to extract EP from vmlinux
 # every time before generation of uImage.
-define Build/calculate-ep
-	$(eval KERNEL_ENTRY=$(shell $(KERNEL_CROSS)readelf -h $(1) | grep "Entry point address" | grep -o 0x.*))
-endef
+kernel_ep = `$(KERNEL_CROSS)readelf -h $(1) | grep "Entry point address" | grep -o 0x.*`
 
 define Build/patch-dtb
 	$(STAGING_DIR_HOST)/bin/patch-dtb $@ $(DTS_DIR)/$(DEVICE_DTS).dtb
@@ -69,9 +67,8 @@ endef
 
 define Image/BuildKernel
 	# Build unified uImage
-	$(call Build/calculate-ep, $(KDIR)/vmlinux.elf)
 	$(call Image/BuildKernel/MkuImage, \
-		none, $(KERNEL_LOADADDR), $(KERNEL_ENTRY), \
+		none, $(KERNEL_LOADADDR),$(call kernel_ep,$(KDIR)/vmlinux.elf) , \
 		$(KDIR)/vmlinux, \
 		$(BIN_DIR)/$(IMG_PREFIX)-uImage \
 	)



More information about the lede-commits mailing list