[source] lantiq: fix lantiq-dsl output spam

LEDE Commits lede-commits at lists.infradead.org
Tue Oct 11 00:46:24 PDT 2016


mkresin pushed a commit to source.git, branch master:
https://git.lede-project.org/0547b3ca64f8d7dfdde65c638d1ff3d2a57b1abb

commit 0547b3ca64f8d7dfdde65c638d1ff3d2a57b1abb
Author: Mathias Kresin <dev at kresin.me>
AuthorDate: Tue Oct 11 09:12:30 2016 +0200

    lantiq: fix lantiq-dsl output spam
    
    In case the adsl/vdsl service is disabled intentional, the output is
    cluttered with the following message multiple times if the status of
    the dsl line is queried:
    
      killall: vdsl_cpe_control: no process killed
    
    If the dsl line status is queried by LuCI, the logfile is spammed with
    the message.
    
    Fix the issue by using killall in quite mode. In quite mode killall
    still returns a non-zero value if the to be killed process can not be
    found so that existing logic based on the return value still works.
    
    Signed-off-by: Mathias Kresin <dev at kresin.me>
---
 target/linux/lantiq/base-files/lib/functions/lantiq_dsl.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/lantiq/base-files/lib/functions/lantiq_dsl.sh b/target/linux/lantiq/base-files/lib/functions/lantiq_dsl.sh
index 41993f7..feaafe6 100755
--- a/target/linux/lantiq/base-files/lib/functions/lantiq_dsl.sh
+++ b/target/linux/lantiq/base-files/lib/functions/lantiq_dsl.sh
@@ -11,7 +11,7 @@ fi
 # Basic functions to send CLI commands to the vdsl_cpe_control daemon
 #
 dsl_cmd() {
-	killall -0 ${XDSL_CTRL} && (
+	killall -q -0 ${XDSL_CTRL} && (
 		lock /var/lock/dsl_pipe
 		echo "$@" > /tmp/pipe/dsl_cpe0_cmd
 		cat /tmp/pipe/dsl_cpe0_ack



More information about the lede-commits mailing list