[source] procd: rework trigger handling
LEDE Commits
lede-commits at lists.infradead.org
Fri Jul 29 07:41:20 PDT 2016
nbd pushed a commit to source.git, branch master:
https://git.lede-project.org/?p=source.git;a=commitdiff;h=8891d941e054331dab027a58dd24e1aeb88acfc3
commit 8891d941e054331dab027a58dd24e1aeb88acfc3
Author: Felix Fietkau <nbd at nbd.name>
AuthorDate: Fri Jul 29 13:00:56 2016 +0200
procd: rework trigger handling
Open/close triggers array around service_triggers call to make using
multiple triggers easier to deal with.
The API was quite confusing, because some functions contained implicit
trigger open/close calls and some didn't.
Signed-off-by: Felix Fietkau <nbd at nbd.name>
---
package/system/procd/files/procd.sh | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/package/system/procd/files/procd.sh b/package/system/procd/files/procd.sh
index 1c2edc6..693a045 100644
--- a/package/system/procd/files/procd.sh
+++ b/package/system/procd/files/procd.sh
@@ -72,7 +72,9 @@ _procd_open_service() {
_procd_close_service() {
json_close_object
+ _procd_open_trigger
service_triggers
+ _procd_close_trigger
_procd_ubus_call set
}
@@ -117,13 +119,27 @@ _procd_open_instance() {
}
_procd_open_trigger() {
+ let '_procd_trigger_open = _procd_trigger_open + 1'
+ [ "$_procd_trigger_open" -gt 1 ] && return
json_add_array "triggers"
}
+_procd_close_trigger() {
+ let '_procd_trigger_open = _procd_trigger_open - 1'
+ [ "$_procd_trigger_open" -lt 1 ] || return
+ json_close_array
+}
+
_procd_open_validate() {
+ json_select ..
json_add_array "validate"
}
+_procd_close_validate() {
+ json_close_array
+ json_select triggers
+}
+
_procd_add_jail() {
json_add_object "jail"
json_add_string name "$1"
@@ -331,14 +347,6 @@ _procd_close_instance() {
json_close_object
}
-_procd_close_trigger() {
- json_close_array
-}
-
-_procd_close_validate() {
- json_close_array
-}
-
_procd_add_instance() {
_procd_open_instance
_procd_set_param command "$@"
More information about the lede-commits
mailing list