[source] samba: update smb template socket options defaults
LEDE Commits
lede-commits at lists.infradead.org
Mon Jul 11 05:20:04 PDT 2016
blogic pushed a commit to source.git, branch master:
https://git.lede-project.org/?p=source.git;a=commitdiff;h=17f4d3967eec59db147d2f5b1c45dc9cf30a883e
commit 17f4d3967eec59db147d2f5b1c45dc9cf30a883e
Author: Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk>
AuthorDate: Wed Jul 6 11:29:34 2016 +0100
samba: update smb template socket options defaults
Removed socket options = TCP_NODELAY IPTOS_LOWDELAY
TCP_NODELAY (disables Nagle algorithm) is default since samba2.
IPTOS_LOWDELAY sets DSCP 0x10 coding (CS2)
The alternate IPTOS_THROUGHPUT sets DSCP 0x08 coding (CS1)
CS1 is a scavenger class, whilst CS2 is more OAM/interactive
(SNMP,SSH,syslog)
Using CS2 is definitely an abuse of DSCP classification, CS1 less so
however even if the ISP takes note of DSCP codings having a default that
sets traffic to CS2 is wrong. Better to use the default Best Effort
class.
Signed-off-by: Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk>
---
package/network/services/samba36/files/smb.conf.template | 1 -
1 file changed, 1 deletion(-)
diff --git a/package/network/services/samba36/files/smb.conf.template b/package/network/services/samba36/files/smb.conf.template
index 7a996b8..48e575a 100644
--- a/package/network/services/samba36/files/smb.conf.template
+++ b/package/network/services/samba36/files/smb.conf.template
@@ -21,7 +21,6 @@
preferred master = yes
security = user
smb passwd file = /etc/samba/smbpasswd
- socket options = TCP_NODELAY IPTOS_LOWDELAY
syslog = 2
use sendfile = yes
writeable = yes
More information about the lede-commits
mailing list