[source] scripts/feeds: Prevent .config autocreation

LEDE Commits lede-commits at lists.infradead.org
Tue Jul 5 23:56:29 PDT 2016

blogic pushed a commit to source.git, branch master:

commit 34527688fcece24641b5ca0bb472c5359df371af
Author: Daniel Dickinson <lede at daniel.thecshore.com>
AuthorDate: Mon Jul 4 04:43:02 2016 -0400

    scripts/feeds: Prevent .config autocreation
    When using scripts/feeds upgrade the .config needs to be
    updated but the code to do so was also autocreating a
    .config if one didn't exist.  This is counter-productive
    when you have not yet used menuconfig (or other config targets)
    because things like selecting or deselecting CONFIG_ALL
    (to build all package by default) only works if the
    package selection has not already been done via an
    existing .config selection.
    Signed-off-by: Daniel Dickinson <lede at daniel.thecshore.com>
 scripts/feeds | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/feeds b/scripts/feeds
index 55a8dd9..045835c 100755
--- a/scripts/feeds
+++ b/scripts/feeds
@@ -534,6 +534,11 @@ sub install_package {
 sub refresh_config {
 	my $default = shift;
+	# Don't create .config if it doesn't already exist so that making a
+	# config only occurs when the user intends it do (however we do
+	# want to refresh an existing config).
+	return if not (-e '.config');
 	# workaround for timestamp check
 	system("rm -f tmp/.packageinfo");

More information about the lede-commits mailing list