[source] procd: Set /dev/kmsg to 600

LEDE Commits lede-commits at lists.infradead.org
Sat Jul 2 07:15:01 PDT 2016


blogic pushed a commit to source.git, branch master:
https://git.lede-project.org/?p=source.git;a=commitdiff;h=8a83ffbefde9879539022c665c4e06f68140e0db

commit 8a83ffbefde9879539022c665c4e06f68140e0db
Author: neheb <rosenp at gmail.com>
AuthorDate: Fri Jul 1 18:32:27 2016 -0700

    procd: Set /dev/kmsg to 600
    
    Small cleanup. I initially though /dev/kmsg was used for dmsg(and journald
    on desktops) but this seems not to be the case. dmsg is still accessible
    as non-root(gives output) which begs the question what does this do? Some
    googling reveals that permissions are set to 600 for some embedded systems
    while 644 for others. I can't find any justification for the latter. Might
    as well err on the side of caution.
    
    Signed-off by: Rosen Penev <rosenp at gmail.com>
---
 package/system/procd/files/hotplug.json | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/system/procd/files/hotplug.json b/package/system/procd/files/hotplug.json
index 85fbb14..e5f8d96 100644
--- a/package/system/procd/files/hotplug.json
+++ b/package/system/procd/files/hotplug.json
@@ -17,10 +17,6 @@
 						]
 					],
 					[ "if",
-						[ "eq", "DEVNAME", "kmsg" ],
-						[ "makedev", "/dev/%DEVNAME%", "0644" ],
-					],
-					[ "if",
 						[ "regex", "DEVNAME", "^snd" ],
 						[ "makedev", "/dev/%DEVNAME%", "0660", "audio" ],
 					],



More information about the lede-commits mailing list