[FS#1324] mac80211: wrong mac address calculation with 2 phy

[LEDE Bugs]

A new Flyspray task has been opened.  Details are below. 

User who did this - Alexander Gerasiov (gerasiov) 

Attached to Project - OpenWrt/LEDE Project
Summary - mac80211: wrong mac address calculation with 2 phy
Task Type - Bug Report
Category - Base system
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Low
Priority - Very Low
Reported Version - Trunk
Due in Version - Undecided
Due Date - Undecided
Details - I'm using current master branch.

In files/lib/wifi/mac80211.sh there is a function mac80211_generate_mac() that tries to generate mac (BSSID) for interfaces. But the is a problem in design here.

I have two phy devices (2,4 and 5GHz):

root at router:/tmp# cat /sys/class/ieee80211/phy*/addresses
xx:xx:xx:xx:2f:2e
xx:xx:xx:xx:2f:2f
root at router:/tmp# cat /sys/class/ieee80211/phy*/address_mask
00:00:00:00:00:07
00:00:00:00:00:07

I also have 4 interfaces in /etc/config/wireless: 2 for radio0 and 2 for radio1. On every channel one is my private AP, and one is for guests.

Since mac80211.sh knows only about phy itself for phy0 is generates ...:2f:2e for main AP and ...:2f:2f for guest one. On phy1 I see :2f:2f for main and 2f:2e for guest.

Since mac addresses goes to bssid (or hostapd creates mac based on bssid in config) I have problem: different AP have the same BSSID.

In my particular case I was able to run the setup after I manually calculate and set macaddresses in /etc/config/wireless

tags: @nbd168 @NeoRaider


More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=1324