[FS#979] ramips: Xiaomi MiWiFi Mini has no configurable LED

[LEDE Bugs]

The following task has a new comment added:

FS#979 - ramips: Xiaomi MiWiFi Mini has no configurable LED
User who did this - Mathias Kresin (mkresin)

----------
> of course it makes sense.

No it doesn't. Please explain why it does make sense to you. I'm sick of crystalball reading. All the time you are claiming something without any prove or even an explanation.

The red LED is handled already by the diag script. As long as the polarity (ACTIVE_HIGH/ACTIVE_LOW) is correct, the LED is set to "on" if the boot finishes. Means, enabling the very same LED once more via 01_leds is a no op.

I rather suspect that the LED GPIOs are GPIO_ACTIVE_HIGH instead of  GPIO_ACTIVE_LOW and the 01_leds config is meant to disable the LED after boot.

Personally I don't like such approach and would use the blue LED for boot status indication and as "boot finished" signal. But since I don't know how it is handled by the stock firmware (and maybe expected by people familiar with the stock firmware), I refrain from saying it is right/wrong the way it is done.

> what would you do, set blue as default?!?

I do not intend to do anything. All I'm interested in is why the led isn't added to the default config as it should be. As I already said, I fail to see - just by looking at the code - why it doesn't happen and I do not have the hardware to do some runtime tests.

> good you figured out finally there is something wrong

Being rude to someone and expecting that the same person fixes the bugs one does encounter might not work as expected...

----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=979#comment3398