[FS#810] Sysupgrade fails since r4188-e96a9a9af8in (ipq806x R7800 NAND device)

[LEDE Bugs]

A new Flyspray task has been opened.  Details are below. 

User who did this - Hannu Nyman (hnyman) 

Attached to Project - LEDE Project
Summary - Sysupgrade fails since r4188-e96a9a9af8in  (ipq806x R7800 NAND device) 
Task Type - Bug Report
Category - Base system
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Low
Priority - Very Low
Reported Version - Trunk
Due in Version - Undecided
Due Date - Undecided
Details - The commit r4188-e96a9a9af8 "sysupgrade: run only one instance at a time." has introduced a bug to the sysupgrade process that prevents the actual sysupgrade. It may not affect all target platforms, but at least ipq806x / R7800, a NAND device, seems to suffer from the bug.

I have written my findings also directly to the commit:
https://github.com/lede-project/source/commit/e96a9a9af82c00dcce606a84a7bb87a00411385d

So far I have only managed to make sysupgrade to work only if I revert the changes done by that commit (manually edit /sbin/sysupgrade file in live router).

I first thought that this is related to LuCI calling sysupgrade twice, but sysupgrade fails also from SSH console.

Details:

Doing sysupgrade from console fails like this:


root at LEDE:~# sysupgrade /tmp/R7800-lede-r4212-abbfcc8525-20170526-1350-sqfs-sysupgrade.tar
Saving config files...
Command failed: Request timed out
root at LEDE:~#


During the time when it tries to do sysupgrade, "ps" run from serial console shows several processes, one of which apparently times out. ubus call to nandupgrade ????


 3425 root      1048 S    -ash
 3434 root      1200 S    {sysupgrade} /bin/sh /sbin/sysupgrade /tmp/R7800-led
 3436 root      1044 S    lock -n /tmp/sysupgrade.lock
 3471 root      1116 S    ubus call system nandupgrade {"path": "/tmp/R7800-le
 3474 root      1044 R    ps



More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=810