[FS#321] BTHomeHub5 Type A dsl_notify.sh fails to set LED

[LEDE Bugs]

The following task has a new comment added:

FS#321 - BTHomeHub5 Type A dsl_notify.sh fails to set LED
User who did this - Mathias Kresin (mkresin)

----------
> ON THE BUG: 

Please do not call it a bug, if you are not doing what you were told to do. My example in the first post **has** "config led 'led_dsl'" from the beginning.

If LuCI adds an anonymous config instead of a named one, it might be a LuCI bug/limitation. It **might** be possible that dsl_notify.sh is using an outdated syntax. But since the named option is set by the ucidef_set_led_* base functions, I tend to point to a LuCI bug/limitation. You find the LuCI bugtracker here: https://github.com/openwrt/luci/issues. Nevertheless, create a new bugreport and do not report multiple issue in a single bugreport. This bugreport is about a complete different issue.

> ON THE LED FEATURE SPECIFIC TO BT HOME HUB 5: 

Please accept that we are not willing to add hacks and code/options - which need to be maintained by someone - just to workaround a limitation that needs to be fixed in the driver. I wrote already that adding support for multicolour LEDs to the gpio-leds driver is a "clean" solution. An alternate way could be to add support for multiple trigger + single LED.

It might be that you are fine with having such hacks. But please consider the amount of devices supported by LEDE. If only half of the devices would have such hacks, maintaining the code would be a nightmare. Some hacks should be kept in your private repository.

Furthermore, I wrote how to contribute by submit patches. Please follow the outlined way or accept that your patches are ignored.

If you want to discuss ideas, use the [[https://forum.lede-project.org|forum]] but do not abuse the bugtracker.

----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=321#comment1526