[FS#321] BTHomeHub5 Type A dsl_notify.sh fails to set LED

[LEDE Bugs]

The following task has a new comment added:

FS#321 - BTHomeHub5 Type A dsl_notify.sh fails to set LED
User who did this - Mathias Kresin (mkresin)

----------
>  I am not impressed with the tone of your replies that discourages participation. You should accept that there are people with points of view and experience that differ from yours and you should make an effort to consider their input. You are a "Project Manager" you should know better.

Seriously? It's like talking to a wall... It's not that I don't consider other peoples input, it's just that I've explained you multiple times what is the issue and you still don't get it. Instead you propose broken and only single board tested solutions over and over again. What you are doing is wasting developer time, since I try to answer every request to encourage participation.

One last try. The HomeHub has "three" LEDs:

  * bthomehubv5a:red:broadband
  * bthomehubv5a:green:broadband
  * bthomehubv5a:blue:broadband

Each of the LEDs can have a trigger. But the HH5a is special in that case. All other boards have a single LED:

  * board:green:broadband

Which can only have **one** trigger. What you are proposing as solution would break exactly these boards, since the netdev trigger set during boot would be overwritten by the trigger set in dsl_notify.sh.

Yes, your hack might work for the HomeHub but it does break all other boards. Try to use only the bthomehubv5a:green:broadband for dsl line state and pppo* state to see what happens.

What you are really looking for is multicolour LED support in gpio-leds driver. Feel free to add multicolour led support to the gpio-leds driver and send your patch to the kernel people for inclusion.

But even that wouldn't work 100% perfect, since a disconnect of the pppo* connection would switch of the broadband LED albeit the underlying dsl line could be still in sync.
----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=321#comment1523