[FS#321] BTHomeHub5 Type A dsl_notify.sh fails to set LED

[LEDE Bugs]

The following task has a new comment added:

FS#321 - BTHomeHub5 Type A dsl_notify.sh fails to set LED
User who did this - Mathias Kresin (mkresin)

----------
I'm getting really annoyed...

I guess it's time for you to accept what you are trying to do is just hackish to make something happen that doesn't really work.

I mean, having a single colour LED switched on in case something is not established is the worst user interaction I can think of. All devices I'm aware of are switching/having switched LEDs off if there is no link/sync/wireless/usb attached or whatever.

Additionally, the concept of triggers is that only one trigger controls the LED. The way you are doing it, the netdev trigger from /etc/config/system gets overwritten either by the none trigger (led_on()/led_off()) or by the timer trigger (led_timer()) while establishing the DSL connection. This clearly indicates that you never tested the patch with a device having only one LED for DSL/Internet (the Homehubs broadband LED is shown as three LEDs - one per colour - in the system). 

Anyway, if you are still the opinion that your approach is worse the work, fix the outlined issues, follow the [[https://lede-project.org/docs/guide-developer/the-source-code#submitting_patches|submitting patches]] guide and provide something that covers all relevant files (dts, board.d etc.).

But please don't reopen this ticket again!
----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=321#comment1515