[FS#321] BTHomeHub5 Type A dsl_notify.sh fails to set LED

[LEDE Bugs]

The following task has a new comment added:

FS#321 - BTHomeHub5 Type A dsl_notify.sh fails to set LED
User who did this - Mauro Mozzarelli (ezplanet)

----------
There is actually a solution to this that allows using the only Broadband "b" LED of this router.

The current implementation of dsl_notify.sh assume that the target LED belongs to the ADSL status only. Instead we want the LED to be shared between the ADSL status and pppoa-wan status.

The way to implement it is to invert the ADSL LED status. So not connected becomes a solid colour, connected becomes OFF. Once connected, the ADSL LED is turned off and pppoa-wan status takes control and here we go. Having a solid or blinking (different colour) for pppoa-wan status implies also that ADSL is connected.

Assuming we assign RED to ADSL and BLUE to pppoa-wan we will have the following states:

ADSL disconnected: SOLID RED
ADSL handshake: RED slow blink
ADSL training:  RED fast blink
ADSL UP: OFF
pppoa-wan disconnected: OFF
pppoa-wan connected SOLID BLUE
pppoa-wan tx/rx Blinking blue

The patch attached inverts the status of the ADSL LED on ADSL UP/DOWN thus allowing the following useful transitions:

RED (ADSL OFF) --> RED slow blink (HANDSHAKE) --> RED fast blink (TRAINING) --> OFF --> SOLID BLUE (pppoa-wan connected) and then Blinking blue if we tick the boxes for pppoa-wan tx rx status.




----------

One or more files have been attached.

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=321#comment1511