[FS#423] Linksys WRT1900ACS USB led names are wrong

[LEDE Bugs]

The following task has a new comment added:

FS#423 - Linksys WRT1900ACS USB led names are wrong
User who did this - howl (howl)

----------
Ok, I have tested it and I have found two things.

First one is that the generated led configuration had caiman instead of shelby in the led names, perhaps you hardcoded the other model to test this. I have just edited caiman to shelby and it works, USB 1 brights up when a usb 2 device is connected, and because it's only usb 2 also with a usb 3 device. USB 2 also brights up with usb 2 and 3 devices because the two ports setup in the led configuration.

The second one is that before testing with devices I set up 255 to the brightness of the leds manually in the sysfs, and found that the third led is also working. The led usb3_2 is there just below the usb3_1, it's a little point similar to the one in the ethernet port to indicate if the link is 100 or 1000 mb. Joining that we can detect if the device in the usb 3 port is 2 or 3 and that third led I have done this to the configuration:

config led 'led_usb1'
	option name 'USB 1'
	option sysfs 'pca963x:shelby:white:usb2'
	option trigger 'usbport'
	list port 'usb1-port1'

config led 'led_usb2'
	option name 'USB 2'
	option sysfs 'pca963x:shelby:white:usb3_1'
	option trigger 'usbport'
	list port 'usb2-port1'
	list port 'usb3-port1'

config led 'led_usb2_2'
	option name 'USB 2-2'
	option sysfs 'pca963x:shelby:white:usb3_2'
	option trigger 'usbport'
	list port 'usb3-port1'

With it if you plug a device in USB 2, if it's 2 the bar get bright, but if it's 3 the bar and the dot below gets bright. I suppose the original firmwares does it but I haven't tested. Anyways it seems that usb3_2 is there for that purpose.

I also opened two days ago a bug in luci asking for usbport trigger configuration that is related to this use case https://github.com/openwrt/luci/issues/971.
----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=423#comment1407