[FS#227] PPPoE is broken on WRT1900ACS

[LEDE Bugs]

The following task has a new comment added:

FS#227 - PPPoE is broken on WRT1900ACS
User who did this - Mathias Kresin (mkresin)

----------
Nice finding.

The as working reported version r1297 has the git commit hash 4e8c6f340751c66a602b98b727af28b2a9004313

The report in the forum is from 2016-08-20. The last commit of this date has the commit hash 35be9284668d19a565d354a33febb508b0e28131 (r1396).

First step would be to test these both commits, to make sure that r1297 works and r1396 is really broken.


$ git checkout master
$ git checkout 4e8c6f340751c66a602b98b727af28b2a9004313
$ make dirclean
$ make menuconfig
$ make



the same with 35be9284668d19a565d354a33febb508b0e28131

If you have a good and a bad version you can use git bisect (git bisect start  ):


$ git checkout master
$ git bisect start 35be9284668d19a565d354a33febb508b0e28131 4e8c6f340751c66a602b98b727af28b2a9004313
$ make dirclean
$ make menuconfig
$ make

$ git bisect good OR git bisect bad
$ make dirclean
$ make menuconfig
$ make

$ git bisect good OR git bisect bad
...


In the end, git bisect will tell you which commit introduced the regression.
----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=227#comment642