[FS#198] image: commit a16a8814ead80984ce4ef7bed756434119b3aafa breaks dnsmasq

[LEDE Bugs]

The following task has a new comment added:

FS#198 - image: commit a16a8814ead80984ce4ef7bed756434119b3aafa breaks dnsmasq
User who did this - Matthias Schiffer (NeoRaider)

----------
Hmm, even before my change, differing umasks would affect the contents of all ipk packages, there was just a fixup for the base images.

I have not checked, but I'd expect the umask will have a direct effect on some files and directories in packages, including the group bit - maybe not a fatal effect, but it will cause differences and thus make reproducible builds more difficult to achieve.

If we don't want to require one specific umask, we'll need to review the practice of copying files from the source tree while preserving mode. I think git only saves a single executable bit, so it would probably make sense to provide a copy command (or change the existing $(CP) in a way) that makes the resulting mode depend on this bit only.
----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=198#comment560