[FS#341] ath10k-firmware Makefile references non-existent QCA9887_BOARD_FILE_MD5 and QCA9887_FIRMWARE_FILE_MD

Sat Dec 17 10:55:55 PST 2016

A new Flyspray task has been opened.  Details are below. 

User who did this - Hannu Nyman (hnyman) 

Attached to Project - LEDE Project
Summary - ath10k-firmware Makefile references non-existent QCA9887_BOARD_FILE_MD5 and QCA9887_FIRMWARE_FILE_MD
Task Type - Bug Report
Category - Base system
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Medium
Priority - Very Low
Reported Version - Trunk
Due in Version - Undecided
Due Date - Undecided
Details - I noticed today a strangely named downloaded file "board.bin." in /dl after an update, and that made me to investigate a bit.

The commit "treewide: clean up download hashes" eliminated all MD5 hashes from the core Makefiles and replaced the _MD5 hash definitions with _HASH definitions:
https://git.lede-project.org/?p=source.git;a=commitdiff;h=720b99215da295a2e7b4acdef30b58bec6acedc2#patch33

But at least two instances of filenames in ath10k-firmware Makefile were left with references to the deleted _MD5 definition, which leads to hash being absent from the filename.

The block with the wrong references is:

https://git.lede-project.org/?p=source.git;a=blob;f=package/firmware/ath10k-firmware/Makefile;h=a0056547485477b71e39860fbe00ee03205147c2;hb=720b99215da295a2e7b4acdef30b58bec6acedc2#l37

QCA9887_FIRMWARE_FILE:=firmware-5.bin_10.2.4-1.0-00013
QCA9887_FIRMWARE_FILE_HASH:=5966408bd41f309edb595344b8dd088c0fed212debfd91e5f3e8a55ea119c16d
QCA9887_FIRMWARE_FILE_DL:=$(QCA9887_FIRMWARE_FILE).$(QCA9887_FIRMWARE_FILE_MD5)
QCA9887_BOARD_FILE:=board.bin
QCA9887_BOARD_FILE_HASH:=cf4df099f6ee05c181f55ce17297a1d32c61d725eb96246fd315ad5587c42426
QCA9887_BOARD_FILE_DL:=$(QCA9887_BOARD_FILE).$(QCA9887_BOARD_FILE_MD5)

Both filenames are intended to include the hash, but due to the wrong variable, hash gets left out.

I am not sure if that causes any actual damage right now, but at least the file name is not like it is intended to be.

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=341