[PATCH 3/5] KVM: RISC-V: remove unnecessary SBI reset state
Anup Patel
anup at brainfault.org
Thu May 8 06:11:08 PDT 2025
On Thu, May 8, 2025 at 3:32 PM Radim Krčmář <rkrcmar at ventanamicro.com> wrote:
>
> 2025-05-08T11:48:00+05:30, Anup Patel <anup at brainfault.org>:
> > On Thu, Apr 3, 2025 at 5:02 PM Radim Krčmář <rkrcmar at ventanamicro.com> wrote:
> >>
> >> The SBI reset state has only two variables -- pc and a1.
> >> The rest is known, so keep only the necessary information.
> >>
> >> The reset structures make sense if we want userspace to control the
> >> reset state (which we do), but I'd still remove them now and reintroduce
> >> with the userspace interface later -- we could probably have just a
> >> single reset state per VM, instead of a reset state for each VCPU.
> >>
> >> Signed-off-by: Radim Krčmář <rkrcmar at ventanamicro.com>
> >
> > Queued this patch for Linux-6.16
>
> [5/5] was already applied, which means that [3/5] would be nicer with
>
> memset(&vcpu->arch.smstateen_csr, 0, sizeof(vcpu->arch.smstateen_csr));
>
> in the new function (kvm_riscv_vcpu_context_reset) where we memset(0)
> the other csr context.
>
> Should I add a patch to do that in v2?
Yes, please add it to your v2. I will update my queue accordingly.
Regards,
Anup
More information about the kvm-riscv
mailing list