[kvm-unit-tests PATCH v11 8/8] riscv: sbi: Add SSE extension tests

Clément Léger cleger at rivosinc.com
Thu Mar 20 06:50:27 PDT 2025



On 20/03/2025 14:46, Andrew Jones wrote:
> ...
>> +cleanup:
>> +	switch (state) {
>> +	case SBI_SSE_STATE_ENABLED:
>> +		ret = sbi_sse_disable(event_id);
>> +		if (ret.error) {
>> +			sbiret_report_error(&ret, SBI_SUCCESS, "disable event 0x%x", event_id);
>> +			break;
>> +		}
>> +	case SBI_SSE_STATE_REGISTERED:
>> +		sbi_sse_unregister(event_id);
>> +		if (ret.error)
>> +			sbiret_report_error(&ret, SBI_SUCCESS, "unregister event 0x%x", event_id);
>> +	default:
> 
> I had to add break here to make clang happy (and same for the other two
> defaults without statements).

Ok. Not directly related but I could/should have added "/* passthrough
*/" comments on the two cases above though.

Thanks,

Clément

> 
> Thanks,
> drew




More information about the kvm-riscv mailing list