[kvm-unit-tests PATCH v2 05/11] riscv: sbi: Improve susp expected error output

[Clément Léger]

On 27/02/2025 15:19, Andrew Jones wrote:
> Improve the output of expected error tests. We don't use
> sbiret_report_error() because we're not passing in an SBI_ERR_*
> name to stringify.
> 
> Signed-off-by: Andrew Jones <andrew.jones at linux.dev>
> ---
>  riscv/sbi.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/riscv/sbi.c b/riscv/sbi.c
> index dd5cb6fa26bf..ceeb0d8d2779 100644
> --- a/riscv/sbi.c
> +++ b/riscv/sbi.c
> @@ -1433,9 +1433,8 @@ static void check_susp(void)
>  			} else if (!params.returns) {
>  				report_fail("unexpected return with error: %ld, value: %ld", ret.error, ret.value);
>  			} else {
> -				report(ret.error == params.ret.error, "expected sbi.error");
> -				if (ret.error != params.ret.error)
> -					report_info("expected error %ld, received %ld", params.ret.error, ret.error);
> +				if (!report(ret.error == params.ret.error, "got expected sbi.error (%ld)", params.ret.error))
> +					report_info("expected sbi.error %ld, received %ld", params.ret.error, ret.error);
>  			}
>  
>  			report_prefix_pop();

Hi Andrew,

LGTM,

Reviewed-by: Clément Léger <cleger at rivosinc.com>

Thanks,

Clément