[kvm-unit-tests PATCH 01/10] riscv: sbi: Mark known fwft failures as kfails

[Clément Léger]

On 21/02/2025 16:55, Andrew Jones wrote:
> Until we fix opensbi mark these known failures as kfails so we can
> pass CI.
> 
> Signed-off-by: Andrew Jones <andrew.jones at linux.dev>
> ---
>  riscv/sbi-fwft.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/riscv/sbi-fwft.c b/riscv/sbi-fwft.c
> index b10c147f22dd..19340d6bb48c 100644
> --- a/riscv/sbi-fwft.c
> +++ b/riscv/sbi-fwft.c
> @@ -63,11 +63,17 @@ static void fwft_check_base(void)
>  		struct sbiret ret;
>  
>  		ret = fwft_get_raw(BIT(32));
> -		sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM,
> +		if (ret.error == 0)
> +			report_kfail(true, false, "get feature with bit 32 set error: SBI_ERR_INVALID_PARAM");
> +		else
> +			sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM,
>  				    "get feature with bit 32 set error");
>  
>  		ret = fwft_set_raw(BIT(32), 0, 0);
> -		sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM,
> +		if (ret.error == 0)
> +			report_kfail(true, false, "set feature with bit 32 set error: SBI_ERR_INVALID_PARAM");
> +		else
> +			sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM,
>  				    "set feature with bit 32 set error");
>  	}
>  #endif
> @@ -167,7 +173,10 @@ static void fwft_check_misaligned_exc_deleg(void)
>  	ret = fwft_misaligned_exc_set(0, SBI_FWFT_SET_FLAG_LOCK);
>  	sbiret_report_error(&ret, SBI_SUCCESS, "Set misaligned deleg feature value 0 and lock");
>  	ret = fwft_misaligned_exc_set(1, 0);
> -	sbiret_report_error(&ret, SBI_ERR_LOCKED,
> +	if (ret.error == SBI_ERR_DENIED)
> +		report_kfail(true, false, "Set locked misaligned deleg feature to new value: SBI_ERR_LOCKED");
> +	else
> +		sbiret_report_error(&ret, SBI_ERR_LOCKED,
>  			    "Set locked misaligned deleg feature to new value");
>  	ret = fwft_misaligned_exc_get();
>  	sbiret_report(&ret, SBI_SUCCESS, 0, "Get misaligned deleg locked value 0");

Hi Andrew,

Reviewed-by: Clément Léger <cleger at rivosinc.com>

Thanks,

Clément