[kvm-unit-tests PATCH v2 1/4] riscv: Drop mstrict-align

Nicholas Piggin npiggin at gmail.com
Tue Sep 10 17:08:23 PDT 2024


On Wed Sep 4, 2024 at 8:50 PM AEST, Andrew Jones wrote:
> The spec says unaligned accesses are supported, so this isn't required
> and clang doesn't support it. A platform might have slow unaligned
> accesses, but kvm-unit-tests isn't about speed anyway.
>
> Reviewed-by: Thomas Huth <thuth at redhat.com>
> Signed-off-by: Andrew Jones <andrew.jones at linux.dev>
> ---
>  riscv/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/riscv/Makefile b/riscv/Makefile
> index 179a373dbacf..2ee7c5bb5ad8 100644
> --- a/riscv/Makefile
> +++ b/riscv/Makefile
> @@ -76,7 +76,7 @@ LDFLAGS += -melf32lriscv
>  endif
>  CFLAGS += -DCONFIG_RELOC
>  CFLAGS += -mcmodel=medany
> -CFLAGS += -mstrict-align
> +#CFLAGS += -mstrict-align

Just remove the line?

Or put a comment there instead to explain.

Thanks,
Nick



More information about the kvm-riscv mailing list