[PATCH V4 6/6] riscv: Test for specific SBI implementation ID

[Carlos Maiolino]

On Thu, Mar 14, 2024 at 09:46:02AM +0100, Andrew Jones wrote:
> On Wed, Mar 13, 2024 at 10:50:57PM +0100, cem at kernel.org wrote:
> > From: Carlos Maiolino <cem at kernel.org>
> >
> > Retrieve the ID from the SBI, and test it against the IMPL_ID
> > enviroment variable.
> >
> > Signed-off-by: Carlos Maiolino <cmaiolino at redhat.com>
> >
> > ---
> > V4:
> > 	- Definitely update to use __base_sbi_ecall
> > V3:
> > 	- Update to use __base_sbi_ecall (also fixes the correct paramenters)
> > 	- Rename env var to IMPL_ID to match the other tests
> > V2:
> > 	- Update commit description to fit 70 chars
> > 	- Move sbi_ecall() after expected assignment to make consistent with
> > 	  other tests
> >
> >  riscv/sbi.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/riscv/sbi.c b/riscv/sbi.c
> > index 043beb04..2a4002df 100644
> > --- a/riscv/sbi.c
> > +++ b/riscv/sbi.c
> > @@ -58,6 +58,14 @@ static void check_base(void)
> >  	}
> >  	report_prefix_pop();
> >
> > +	report_prefix_push("impl_id");
> > +	if (env_or_skip("IMPL_ID")) {
> > +		expected = strtol(getenv("IMPL_ID"), NULL, 0);
> > +		ret = __base_sbi_ecall(SBI_EXT_BASE_GET_IMP_ID, 0);
> > +		gen_report(&ret, 0, expected);
> > +	}
> > +	report_prefix_pop();
> > +
> >  	report_prefix_push("probe_ext");
> >  	expected = getenv("PROBE_EXT") ? strtol(getenv("PROBE_EXT"), NULL, 0) : 1;
> >  	ret = __base_sbi_ecall(SBI_EXT_BASE_PROBE_EXT, SBI_EXT_BASE);
> > --
> > 2.44.0
> >
> 
> I adjusted the order of the tests to match the function order in the spec
> while queuing.
> 

Sounds good, thanks!
Carlos