[PATCH 1/6] riscv: Add a wrapper to call sbi_ecall for base extension

Andrew Jones ajones at ventanamicro.com
Wed Mar 13 12:24:15 PDT 2024


On Wed, Mar 13, 2024 at 03:53:24PM +0100, cem at kernel.org wrote:
> From: Carlos Maiolino <cem at kernel.org>
> 
> All SBI extension functions accepts at most one argument, so create a
> wrapper around sbi_ecall() to avoid needing to pass in arguments 1 to 5
> all the time, also, the wrapper can specify SBI_EXT_BASE directly.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino at redhat.com>
> ---
> V3:
> 	- Move to the beginning of the series
> 	- Don't mark __base_sbi_ecall() as inline
> V2:
> 	- This patch was introduced in V2
> 
>  riscv/sbi.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/riscv/sbi.c b/riscv/sbi.c
> index ffb07a25..48d0b06e 100644
> --- a/riscv/sbi.c
> +++ b/riscv/sbi.c
> @@ -14,7 +14,13 @@ static void help(void)
>  	puts("An environ must be provided where expected values are given.\n");
>  }
>  
> +static struct sbiret __base_sbi_ecall(int fid, unsigned long arg0)
> +{
> +	return sbi_ecall(SBI_EXT_BASE, fid, arg0, 0, 0, 0, 0, 0);
> +}
> +
>  int main(int argc, char **argv)
> +

stray blank line

>  {
>  	struct sbiret ret;
>  	long expected;
> @@ -32,7 +38,7 @@ int main(int argc, char **argv)
>  	}
>  	expected = strtol(getenv("MVENDORID"), NULL, 0);
>  
> -	ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_GET_MVENDORID, 0, 0, 0, 0, 0, 0);
> +	ret = __base_sbi_ecall(SBI_EXT_BASE_GET_MVENDORID, 0);
>  	report(!ret.error, "mvendorid: no error");
>  	report(ret.value == expected, "mvendorid");
>  
> -- 
> 2.44.0
> 

Reviewed-by: Andrew Jones <ajones at ventanamicro.com>



More information about the kvm-riscv mailing list