[PATCH 00/26] KVM: vfio: Hide KVM internals from others

[Shameerali Kolothum Thodi]

> -----Original Message-----
> From: Sean Christopherson <seanjc at google.com>
> Sent: Monday, June 24, 2024 4:32 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi at huawei.com>
> Cc: Catalin Marinas <catalin.marinas at arm.com>; Will Deacon
> <will at kernel.org>; Marc Zyngier <maz at kernel.org>; Oliver Upton
> <oliver.upton at linux.dev>; Huacai Chen <chenhuacai at kernel.org>; Michael
> Ellerman <mpe at ellerman.id.au>; Anup Patel <anup at brainfault.org>; Paul
> Walmsley <paul.walmsley at sifive.com>; Palmer Dabbelt
> <palmer at dabbelt.com>; Albert Ou <aou at eecs.berkeley.edu>; Heiko
> Carstens <hca at linux.ibm.com>; Vasily Gorbik <gor at linux.ibm.com>;
> Alexander Gordeev <agordeev at linux.ibm.com>; Christian Borntraeger
> <borntraeger at linux.ibm.com>; Janosch Frank <frankja at linux.ibm.com>;
> Claudio Imbrenda <imbrenda at linux.ibm.com>; Thomas Gleixner
> <tglx at linutronix.de>; Ingo Molnar <mingo at redhat.com>; Borislav Petkov
> <bp at alien8.de>; Dave Hansen <dave.hansen at linux.intel.com>;
> x86 at kernel.org; Peter Zijlstra <peterz at infradead.org>; Arnaldo Carvalho de
> Melo <acme at kernel.org>; Paolo Bonzini <pbonzini at redhat.com>; Tony
> Krowiak <akrowiak at linux.ibm.com>; Halil Pasic <pasic at linux.ibm.com>;
> Jason Herne <jjherne at linux.ibm.com>; Harald Freudenberger
> <freude at linux.ibm.com>; Alex Williamson <alex.williamson at redhat.com>;
> Andy Lutomirski <luto at kernel.org>; linux-arm-kernel at lists.infradead.org;
> kvmarm at lists.linux.dev; linux-mips at vger.kernel.org; kvm at vger.kernel.org;
> linuxppc-dev at lists.ozlabs.org; kvm-riscv at lists.infradead.org; linux-
> riscv at lists.infradead.org; linux-s390 at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-perf-users at vger.kernel.org; Anish Ghulati
> <aghulati at google.com>; Venkatesh Srinivas <venkateshs at chromium.org>;
> Andrew Thornton <andrewth at google.com>
> Subject: Re: [PATCH 00/26] KVM: vfio: Hide KVM internals from others
> 
> On Thu, Jun 20, 2024, Shameerali Kolothum Thodi wrote:
> > > This is a borderline RFC series to hide KVM's internals from the rest of
> > > the kernel, where "internals" means data structures, enums, #defines,
> > > APIs, etc. that are intended to be KVM-only, but are exposed
> everywhere
> > > due to kvm_host.h (and other headers) living in the global include paths.
> >
> > Hi Sean,
> >
> > Just thought of checking with you on this series. Do you have plans to
> revive this
> > series?
> 
> Yep!
> 
> > The reason I am asking is, on ARM64/KVM side we do have a requirement
> > to share the KVM VMID with SMMUV3. Please see the RFC I sent out
> earlier this
> > year[1]. The series basically provides a way for KVM to pin a VMID and also
> > associates an iommufd ctx with a struct kvm * to retrieve that VMID.
> >
> > As mentioned above, some of the patches in this series(especially 1-4 & 6)
> that
> > does the VFIO cleanups and dropping CONFIG_KVM_VFIO looks very
> straightforward
> > and useful. I am thinking of including those when I re-spin my RFC series, if
> > that’s ok.
> 
> Please don't include them, as the patch they build towards (patch 5) is
> buggy[*],
> and I am fairly certain that at least some of the patches will change
> significantly.

Ok. Got it. Thanks for taking a look at the KVM pinned VMID series and comments
there.

Shameer