[PATCH v2 kvm-riscv/for-next 1/2] drivers/perf: riscv: Remove the warning from stop function
Atish Patra
atishp at rivosinc.com
Thu Apr 25 20:16:36 PDT 2024
The warning message was initially added just to indicate that counter
stop function is being called while the event is already stopped.
However, we update the state to stopped case now in an overflow handler
after stopping the counter. If there is another child overflow handler
is registered (e.g kvm) it may call stop again which will trigger the
warning.
Fixes: 22f5dac41004 ("drivers/perf: riscv: Implement SBI PMU snapshot function")
Reviewed-by: Samuel Holland <samuel.holland at sifive.com>
Signed-off-by: Atish Patra <atishp at rivosinc.com>
---
drivers/perf/riscv_pmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/perf/riscv_pmu.c b/drivers/perf/riscv_pmu.c
index 36d348753d05..78c490e0505a 100644
--- a/drivers/perf/riscv_pmu.c
+++ b/drivers/perf/riscv_pmu.c
@@ -191,8 +191,6 @@ void riscv_pmu_stop(struct perf_event *event, int flags)
struct hw_perf_event *hwc = &event->hw;
struct riscv_pmu *rvpmu = to_riscv_pmu(event->pmu);
- WARN_ON_ONCE(hwc->state & PERF_HES_STOPPED);
-
if (!(hwc->state & PERF_HES_STOPPED)) {
if (rvpmu->ctr_stop) {
rvpmu->ctr_stop(event, 0);
--
2.34.1
More information about the kvm-riscv
mailing list