[RFC PATCH v11 01/29] KVM: Wrap kvm_gfn_range.pte in a per-action union

Jarkko Sakkinen jarkko at kernel.org
Wed Jul 19 06:39:23 PDT 2023


On Wed Jul 19, 2023 at 2:44 AM EEST, Sean Christopherson wrote:
>  	/* Huge pages aren't expected to be modified without first being zapped. */
> -	WARN_ON(pte_huge(range->pte) || range->start + 1 != range->end);
> +	WARN_ON(pte_huge(range->arg.pte) || range->start + 1 != range->end);

Not familiar with this code. Just checking whether whether instead
pr_{warn,err}() combined with return false would be a more graceful
option?

BR, Jarkko



More information about the kvm-riscv mailing list