[PATCH v6 18/22] KVM: x86/mmu: Extend make_huge_page_split_spte() for the shadow MMU

Sean Christopherson seanjc at google.com
Fri Jun 17 09:56:11 PDT 2022

On Mon, May 16, 2022, David Matlack wrote:
> Currently make_huge_page_split_spte() assumes execute permissions can be
> granted to any 4K SPTE when splitting huge pages. This is true for the
> TDP MMU but is not necessarily true for the shadow MMU, since KVM may be
> shadowing a non-executable huge page.
> To fix this, pass in the role of the child shadow page where the huge
> page will be split and derive the execution permission from that.  This
> is correct because huge pages are always split with direct shadow page
> and thus the shadow page role contains the correct access permissions.
> No functional change intended.
> Signed-off-by: David Matlack <dmatlack at google.com>
> ---

Reviewed-by: Sean Christopherson <seanjc at google.com>

More information about the kvm-riscv mailing list