<br><br><div class="gmail_quote">2010/5/12 Christian Kujau <span dir="ltr"><<a href="mailto:lists@nerdbynature.de">lists@nerdbynature.de</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Maxim Uvarov wrote on 2010-05-11 10:47 :<br>
<div class="im">> This patch is required in case if you are using new toolchains.<br>
<br>
</div>I'm on Debian/stable (binutils 2.18, gcc 4.3.2), so I applied your patches<br>
to the latest -git checkout:<br>
<br>
First, compilation fails with:<br>
<br>
cc1: warnings being treated as errors<br>
kexec/arch/ppc/kexec-ppc.c: In function ‘get_base_ranges’:<br>
kexec/arch/ppc/kexec-ppc.c:258: error: value computed is not used<br>
make: *** [kexec/arch/ppc/kexec-ppc.o] Error 1<br>
<br>
Somehow a "-" hyphen made it into one of the functions:<br>
<br>
> --- a/kexec/arch/ppc/kexec-ppc.c<br>
<div class="im">> +++ b/kexec/arch/ppc/kexec-ppc.c<br>
</div>[...]<br>
<div class="im">> if (local_memory_ranges >= max_memory_ranges) {<br>
> - fclose(file);<br>
> - break;<br>
> + if (realloc_memory_ranges() < 0){<br>
> + - fclose(file);<br>
<br></div></blockquote><div>Oh, I sent this patch twice with stg -a by mistake. And second version has "-". I will fix and resend patches.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">
<br>
</div>Removing this, gets me further, until:<br>
<br>
<br>
purgatory/arch/ppc/crt.o: In function `__lshrdi3':<br>
(.text+0xf0): multiple definition of `__lshrdi3'<br>
purgatory/arch/ppc/misc.o:(.text+0x50): first defined here<br>
collect2: ld returned 1 exit status<br>
make: *** [purgatory/<a href="http://purgatory.ro" target="_blank">purgatory.ro</a>] Error 1<br>
<br>
And has been defined in purgatory/arch/ppc/crt.S and<br>
./purgatory/arch/ppc/misc.S. Removing it from e.g. crt.S<br>
makes it compile, I have not tested it yet, though :-)<br></blockquote><div><br>Yes, that is expected result for old tool chains. New tool chains (from code sourcery ) need this crt.S.<br>I think we can have --with-oldtoolchain option to configure to point to old tool chains. (or even rename it to --with-crts,<br>
I don't know what is better.)<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Thanks,<br>
Christian.<br>
<br>
PS: Where is -Werror defined? I could not find it anywhere in the kexec<br>
source (execpt in arch/mips)...<br>
<font color="#888888">--<br></font></blockquote><div><br>This -Werror came from mips. kexec/arch/mips/Makefile. It is already removed in the git. We already saw this problem.<br><br><br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<font color="#888888">
make bzImage, not war<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Best regards,<br>Maxim Uvarov<br>