<br><br><div class="gmail_quote">2010/5/5 Simon Horman <span dir="ltr"><<a href="mailto:horms@verge.net.au">horms@verge.net.au</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Wed, May 05, 2010 at 01:35:21PM +1000, Michael Neuling wrote:<br>
><br>
><br>
> In message <<a href="mailto:20100505023316.GF13035@verge.net.au">20100505023316.GF13035@verge.net.au</a>> you wrote:<br>
> > On Wed, May 05, 2010 at 11:48:53AM +1000, Michael Neuling wrote:<br>
> > > 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS<br>
> > > improvements" broke pp64 as it turned on -Werror for all archs.<br>
> > ><br>
> > > This fixes the warning and hence ppc64 building.<br>
> ><br>
> > Thanks.<br>
> ><br>
> > While I'm very much in favour of using -Werror for testing<br>
> > and these kind of patches are great, I think that -Werror<br>
> > by default is rather silly. We can't control what will be<br>
> > a warning in the future and sometimes fixing warnings isn't<br>
> > appropriate - for instance there are warnings in fs2dt.c at<br>
> > the moment, that is currently considered an upstream problem.<br>
> ><br>
> > In short, this patch is great. But I plan to also remove -Werror<br>
> > as the default now that its been brought to my attention.<br>
><br>
> Cool. My second patch should do this for all but MIPS.<br>
<br>
</div>Unfortunately the second patch breaks make tarball.<br>
For now I have committed the following:<br>
<br>