This avoids comparisons between signed and unsigned integers. Signed-off-by: Simon Horman Index: kexec-tools/kexec/arch/sh/kexec-sh.c =================================================================== --- kexec-tools.orig/kexec/arch/sh/kexec-sh.c 2010-02-01 23:07:20.000000000 +1100 +++ kexec-tools/kexec/arch/sh/kexec-sh.c 2010-02-01 23:07:22.000000000 +1100 @@ -164,10 +164,10 @@ char *get_append(void) return append_buf; } -void kexec_sh_setup_zero_page(char *zero_page_buf, int zero_page_size, +void kexec_sh_setup_zero_page(char *zero_page_buf, size_t zero_page_size, char *cmd_line) { - int n = zero_page_size - 0x100; + size_t n = zero_page_size - 0x100; memset(zero_page_buf, 0, zero_page_size); Index: kexec-tools/kexec/arch/sh/kexec-sh.h =================================================================== --- kexec-tools.orig/kexec/arch/sh/kexec-sh.h 2010-02-01 23:06:38.000000000 +1100 +++ kexec-tools/kexec/arch/sh/kexec-sh.h 2010-02-01 23:07:22.000000000 +1100 @@ -23,7 +23,7 @@ int netbsd_sh_load(int argc, char **argv void netbsd_sh_usage(void); char *get_append(void); -void kexec_sh_setup_zero_page(char *zero_page_buf, int zero_page_size, +void kexec_sh_setup_zero_page(char *zero_page_buf, size_t zero_page_size, char *cmd_line); #endif /* KEXEC_SH_H */ Index: kexec-tools/kexec/arch/sh/kexec-zImage-sh.c =================================================================== --- kexec-tools.orig/kexec/arch/sh/kexec-zImage-sh.c 2010-02-01 23:07:19.000000000 +1100 +++ kexec-tools/kexec/arch/sh/kexec-zImage-sh.c 2010-02-01 23:07:22.000000000 +1100 @@ -51,7 +51,7 @@ static unsigned long zImage_head32(const * * Make sure that the file image has a reasonable chance of working. */ -int zImage_sh_probe(const char *buf, off_t len) +int zImage_sh_probe(const char *buf, off_t UNUSED(len)) { if (memcmp(&buf[0x202], "HdrS", 4) != 0) return -1;