<br><br><div class="gmail_quote">2008/10/15 Simon Horman <span dir="ltr"><<a href="mailto:horms@verge.net.au">horms@verge.net.au</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Tue, Oct 14, 2008 at 07:11:19PM +0400, Maxim Uvarov wrote:<br>
> Hello all,<br>
><br>
> As you all know it is not easy to count exact value of memory ranges from<br>
> device tree on powerpc.<br>
> It very depends on how dts file was written. What do you think about really<br>
> dynamic allocation buffers<br>
> for this buffers?<br>
<br>
</div>Conceptually I have no objections to the change,<br>
though I would like to get some review from ppc people.<br>
(<a href="mailto:linuxppc-dev@ozlabs.org">linuxppc-dev@ozlabs.org</a> CCed)<br>
<br>
> Patch is attached.<br>
<br>
This patch doesn't seem to compile for me.<br>
<br>
# powerpc64-unknown-linux-gnu-gcc --version<br>
powerpc64-unknown-linux-gnu-gcc (GCC) 4.1.1<br>
Copyright (C) 2006 Free Software Foundation, Inc.<br>
This is free software; see the source for copying conditions. There is NO<br>
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.<br>
<br>
#make<br>
[snip]<br>
kexec/arch/ppc64/kexec-ppc64.c:100: warning: function declaration isn't a<br>
prototype<br>
kexec/arch/ppc64/kexec-ppc64.c: In function 'realloc_memory_ranges':<br>
kexec/arch/ppc64/kexec-ppc64.c:107: warning: passing argument 1 of 'realloc' makes pointer from integer without a cast<br>
kexec/arch/ppc64/kexec-ppc64.c:107: error: too few arguments to function 'realloc'<br>
kexec/arch/ppc64/kexec-ppc64.c:102: warning: unused variable 'tmp'<br>
<font color="#888888"></font></blockquote><div>Sorry I edited manually formated patch before sending and lost first argument to realloc. I will resend it. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<font color="#888888"><br>
--<br>
Simon Horman<br>
VA Linux Systems Japan K.K., Sydney, Australia Satellite Office<br>
H: <a href="http://www.vergenet.net/%7Ehorms/" target="_blank">www.vergenet.net/~horms/</a> W: <a href="http://www.valinux.co.jp/en" target="_blank">www.valinux.co.jp/en</a><br>
<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Best regards,<br>Maxim Uvarov<br>