<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><DIV>This isn't a high priority issue- just something I am looking at in my spare time. I would appreciate any advice you can provide.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>I am looking through some of the kexec elf relocation code, and noticed that reloc_name is only defined for x86_64. I started writing this function for the other architectures, but noticed that some of the other architectures do not have contiguous r_type numbers (from include/elf.h). In the x86_64 reloc_name code, r_name is an array of strings with all of the relocation names. I can't (AFAIK) use a similar approach to architectures with non-contiguous r_type numbers.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>My questions:</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Is it valuable to print out the relocation type as a string? (I personally find it helpful)</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>If so, should the reloc_name function still reside in the kexec-elf-rel-$ARCH.c file? There are 81 IA64 relocations, which make the file considerably longer.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>If not, should there be consistency between the different architectures with regards to these types of error messages? Should the X86_64 file print out the r_type instead of the string?</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Thanks,</DIV><DIV><BR><DIV> <SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>********************************************</DIV><DIV>Kevin Tegtmeier</DIV><DIV>HPC-3 Scientific Computing Resources</DIV><DIV>Los Alamos National Laboratory</DIV><DIV>email: kevint at lanl dot gov</DIV><DIV>********************************************</DIV><DIV><BR class="khtml-block-placeholder"></DIV><BR class="Apple-interchange-newline"></SPAN> </DIV><BR></DIV></BODY></HTML>