[PATCH v2 22/47] mm/gup: check for overflow when converting nr_pages to bytes in GUP-fast
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu Oct 29 20:41:20 PDT 2026
> The overflow check in gup_fast_fallback() only covers the addition to
> start. The preceding nr_pages << PAGE_SHIFT can already have truncated
> the length on 32bit.
>
> Users such as RapidIO's rio_dma_transfer() can derive such page counts
> from a 64-bit userspace length.
>
> Let's just check_shl_overflow() to reject any such overflow with
> -EOVERFLOW early.
>
> Fixes: c28b1fc70390 ("mm/gup: reorganize internal_get_user_pages_fast()")
> Cc: stable at vger.kernel.org
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs at kernel.org>
> Acked-by: Muchun Song <muchun.song at linux.dev>
> Reviewed-by: Barry Song <baohua at kernel.org>
> Signed-off-by: David Hildenbrand (Arm) <david at kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org?part=22
More information about the kexec
mailing list