[PATCH] kexec: fix stack buffer overflow in update_purgatory()
zhangzikang1992 at 126.com
zhangzikang1992 at 126.com
Thu Oct 29 20:09:18 PDT 2026
From: zhangzikang <zhangzikang at kylinos.cn>
Problem:
A stack buffer overflow exists in "update_purgatory()". The local array "sha256_region region[SHA256_REGIONS]" (size 16) is written during iteration over "info->nr_segments" without boundary checking for the write index "j".
"Add_degment_phys-virt()" only issues a warning when "nr_degments" exceeds "KEXEC_MAX_SGMENTS" (=16) and continues to append segments. Therefore, "update_purgation()" may be called, causing "nr_degments" to be much larger than "SHA256-REGIONS", resulting in "region [j]" being written outside of the 16 item stack array. This type of out of bounds write will damage the Canary stack and adjacent stack frames.
Impact:
Stack buffer overflow causing process crash (resulting in denial of service through Canary termination); The potential for controllable stack destruction depends on the content of the image.
Fix:
Before writing to "region[j]" in "update_purgatory()", add a bounds check on "j" to ensure that writing stops immediately when "j" reaches "SHA256_REGIONS", preventing out-of-bounds writes from corrupting adjacent global variables.
Signed-off-by: zhangzikang <zhangzikang at kylinos.cn>
---
kexec/kexec.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kexec/kexec.c b/kexec/kexec.c
index c9e4bcb..732058e 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -728,6 +728,11 @@ static void update_purgatory(struct kexec_info *info)
sha256_update(&ctx, null_buf, bytes);
nullsz -= bytes;
}
+ if (j >= SHA256_REGIONS) {
+ fprintf(stderr, "Warning: SHA256 region limit reached. "
+ "Skipping remaining segments from checksum region list\n");
+ break;
+ }
region[j].start = (unsigned long) info->segment[i].mem;
region[j].len = info->segment[i].memsz;
j++;
--
2.43.0
More information about the kexec
mailing list