[PATCH v2 3/3] ima: clear kexec state when replacing file image
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu Nov 12 05:08:24 PST 2026
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] kexec: skipped ima_kexec_cleanup() with crash flags when
!CONFIG_CRASH_DUMP
--
commit bddeb1d64059b337f4ac9e46300e35fd5ccaa690
Author: Jérémy Jean <Jeremy.Jean at oss.cyber.gouv.fr>
ima: clear kexec state when replacing file image
This commit tracks the kimage associated with ima_kexec_buffer and clears
the IMA kexec state when a normal kexec image is unloaded or replaced via
kexec_load() or kexec_file_load().
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 90756dc6339b0..297f4657869bc 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
[ ... ]
> @@ -114,6 +115,10 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments,
>
> if (nr_segments == 0) {
> /* Uninstall image */
> +#ifdef CONFIG_IMA_KEXEC
> + if (!(flags & KEXEC_ON_CRASH))
> + ima_kexec_cleanup();
> +#endif
> kimage_free(xchg(dest_image, NULL));
> ret = 0;
> goto out_unlock;
> @@ -163,6 +168,12 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments,
> if (ret)
> goto out;
>
> + /* A kexec_load image has no IMA measurement segment. */
> +#ifdef CONFIG_IMA_KEXEC
> + if (!(flags & KEXEC_ON_CRASH))
> + ima_kexec_cleanup();
> +#endif
> +
> /* Install the new kernel and uninstall the old */
> image = xchg(dest_image, image);
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 6c5724aa3c749..866601712e994 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -399,8 +399,13 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd,
> #endif
> dest_image = &kexec_image;
>
> - if (flags & KEXEC_FILE_UNLOAD)
> + if (flags & KEXEC_FILE_UNLOAD) {
> +#ifdef CONFIG_IMA_KEXEC
> + if (image_type == KEXEC_TYPE_DEFAULT)
> + ima_kexec_cleanup();
> +#endif
> goto exchange;
> + }
[Severity: Medium]
Can these checks skip ima_kexec_cleanup() while still freeing kexec_image
when CONFIG_CRASH_DUMP is disabled?
In both do_kexec_load() and SYSCALL_DEFINE5(kexec_file_load), selecting
kexec_crash_image is guarded by CONFIG_CRASH_DUMP:
kernel/kexec.c:do_kexec_load() {
...
#ifdef CONFIG_CRASH_DUMP
if (flags & KEXEC_ON_CRASH) {
dest_image = &kexec_crash_image;
if (kexec_crash_image)
arch_kexec_unprotect_crashkres();
} else
#endif
dest_image = &kexec_image;
...
}
When CONFIG_IMA_KEXEC=y and CONFIG_CRASH_DUMP=n, calling kexec_load() with
KEXEC_ON_CRASH or kexec_file_load() with KEXEC_FILE_UNLOAD |
KEXEC_FILE_ON_CRASH sets dest_image to &kexec_image and frees the active
kexec_image, but the !(flags & KEXEC_ON_CRASH) and image_type ==
KEXEC_TYPE_DEFAULT checks skip ima_kexec_cleanup(). That leaves
ima_kexec_buffer mapped to freed pages and ima_kexec_image dangling; if a
subsequent load allocates a new struct kimage at the same slab address,
ima_update_kexec_buffer() sees ima_kexec_image == kexec_image and writes
the measurement list into the freed pages (use-after-free).
Checking dest_image == &kexec_image instead would match the image actually
being replaced or unloaded.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112125246.2715174-2-Jeremy.Jean@oss.cyber.gouv.fr?part=3
More information about the kexec
mailing list