[PATCH RESEND v2 04/23] proc: wait for the last user of an entry with wait_var_event()
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu Nov 5 11:35:20 PST 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] proc: missing acquire ordering in proc_entry_rundown() wait_var_event()
--
commit 983e734e20cf0803ce3936df6614c8375020b212
Author: Christian Brauner <brauner at kernel.org>
proc: wait for the last user of an entry with wait_var_event()
This commit replaces the per-entry pde_unload_completion pointer in
struct proc_dir_entry with wait_var_event() and wake_up_var() on
pde->in_use during proc_entry_rundown().
> diff --git a/fs/proc/inode.c b/fs/proc/inode.c
> index 66a3688757dd7..8795add1898dc 100644
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
[ ... ]
> @@ -266,11 +267,9 @@ static void close_pdeo(struct proc_dir_entry *pde, struct pde_opener *pdeo)
>
> void proc_entry_rundown(struct proc_dir_entry *de)
> {
> - DECLARE_COMPLETION_ONSTACK(c);
> /* Wait until all existing callers into module are done. */
> - de->pde_unload_completion = &c;
> if (atomic_add_return(BIAS, &de->in_use) != BIAS)
> - wait_for_completion(&c);
> + wait_var_event(&de->in_use, atomic_read(&de->in_use) == BIAS);
[Severity: Medium]
Should the condition in wait_var_event() use atomic_read_acquire(&de->in_use)
instead of atomic_read(&de->in_use)?
When remove_proc_entry(), remove_proc_subtree(), or proc_remove() calls
proc_entry_rundown(de) while another CPU is executing an in-flight proc
callback, atomic_add_return(BIAS, &de->in_use) returns a value not equal to
BIAS. If that callback finishes and executes atomic_dec_return(&pde->in_use)
in unuse_pde() before proc_entry_rundown() evaluates the wait condition,
wait_var_event() takes its initial fast path:
include/linux/wait_bit.h:
#define wait_var_event(var, condition) \
do { \
might_sleep(); \
if (condition) \
break; \
__wait_var_event(var, condition); \
} while (0)
Because atomic_read() is relaxed, breaking out on the initial check neither
takes the waitqueue lock nor issues an acquire barrier. On weakly-ordered
architectures, memory accesses performed after proc_entry_rundown() (such as
freeing or reading private data after remove_proc_entry() returns, especially
once the subsequent patch in this series skips pde_unload_lock when
!de->open) could be reordered before memory accesses made by the proc
callback prior to unuse_pde().
Previously, complete() and wait_for_completion() unconditionally provided
release-acquire ordering via the completion waitqueue lock, and the
documentation for wait_var_event() notes that the condition should use
smp_load_acquire() or a similarly ordered access so memory changes made
before the condition became true are visible after the wait completes.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-work-procfs-core-v2-0-76ace653a773@kernel.org?part=4
More information about the kexec
mailing list