[PATCH RFC 08/16] selftests/proc: check that a faulting reader doesn't hold up removal

sashiko-bot at kernel.org sashiko-bot at kernel.org
Tue Nov 3 07:01:17 PST 2026


Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/proc: Makefile and .gitignore entries in wrong commit
--

commit 9de4ed28fcd6656e6c6c2bb55f1514d9aa6600f6
Author: Christian Brauner <brauner at kernel.org>

selftests/proc: check that a faulting reader doesn't hold up removal

This commit adds a selftest in tools/testing/selftests/proc/proc-remove-slow-reader.c
that verifies removing a /proc/net/dev_snmp6/<dev> entry does not block when a
concurrent reader faults while copying to userspace via userfaultfd.

> diff --git a/tools/testing/selftests/proc/proc-remove-slow-reader.c b/tools/testing/selftests/proc/proc-remove-slow-reader.c
> new file mode 100644
> index 0000000000000..a201645beca9d
> --- /dev/null
> +++ b/tools/testing/selftests/proc/proc-remove-slow-reader.c
> @@ -0,0 +1,133 @@
[ ... ]
> +TEST(remove_while_reader_faults)
> +{

[Severity: Low]
Should this commit also include the corresponding tools/testing/selftests/proc/Makefile
and tools/testing/selftests/proc/.gitignore entries for proc-remove-slow-reader?

In the current series, those entries:

  tools/testing/selftests/proc/Makefile:
    TEST_GEN_PROGS += proc-remove-slow-reader

  tools/testing/selftests/proc/.gitignore:
    /proc-remove-slow-reader

were placed in the earlier commit ("selftests/proc: check that a faulting
readlink() doesn't hold up removal") before proc-remove-slow-reader.c exists.
Building tools/testing/selftests/proc at that earlier commit or any intermediate
commit before this one fails due to the missing source file, breaking bisection,
and cherry-picking this commit on its own leaves the new test unbuilt.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-work-procfs-core-v1-0-75df35e4f8b8@kernel.org?part=8



More information about the kexec mailing list