[PATCH RFC 38/38] selftests/proc: check that a faulting readlink() doesn't hold up removal
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Tue Nov 3 06:48:45 PST 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] selftests/proc: Makefile adds nonexistent proc-remove-slow-reader target
--
commit ac0073c08526e8690efa58576485d79bbd906522
Author: Christian Brauner <brauner at kernel.org>
selftests/proc: check that a faulting readlink() doesn't hold up removal
This commit adds a selftest verifying that a readlink() call faulting via
userfaultfd on /proc/asound/<id> does not block removal of the /proc symlink
when renaming a dummy sound card.
> diff --git a/tools/testing/selftests/proc/.gitignore b/tools/testing/selftests/proc/.gitignore
> index 7b81334927820..e2566cc0ae079 100644
> --- a/tools/testing/selftests/proc/.gitignore
> +++ b/tools/testing/selftests/proc/.gitignore
> @@ -22,6 +22,8 @@
> /proc-uptime-002
> /proc-pidns
> /proc-remove-slow-sysctl
> +/proc-remove-slow-reader
> +/proc-remove-slow-readlink
> /read
> /self
> /setns-dcache
> diff --git a/tools/testing/selftests/proc/Makefile b/tools/testing/selftests/proc/Makefile
> index bce6beca72744..6a9bdc999f545 100644
> --- a/tools/testing/selftests/proc/Makefile
> +++ b/tools/testing/selftests/proc/Makefile
> @@ -33,5 +33,7 @@ TEST_GEN_PROGS += proc-fsconfig-hidepid
> TEST_GEN_PROGS += proc-sysctl-readdir-churn
> TEST_GEN_PROGS += proc-pidns
> TEST_GEN_PROGS += proc-remove-slow-sysctl
> +TEST_GEN_PROGS += proc-remove-slow-reader
[Severity: Medium]
Was proc-remove-slow-reader added to TEST_GEN_PROGS in
tools/testing/selftests/proc/Makefile (and to
tools/testing/selftests/proc/.gitignore) by mistake?
This patch adds tools/testing/selftests/proc/proc-remove-slow-readlink.c, but
tools/testing/selftests/proc/proc-remove-slow-reader.c does not exist in the
tree. Because the default all target in tools/testing/selftests/lib.mk depends
on $(TEST_GEN_PROGS), building the proc selftests fails with no rule to make
target proc-remove-slow-reader.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-work-procfs-bugfixes-v1-0-59422ed3e465@kernel.org?part=38
More information about the kexec
mailing list