[PATCH RFC 23/38] proc: don't let NOMMU map procfs files
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Tue Nov 3 06:48:11 PST 2026
> Every procfs file has a ->mmap since commit 786d7e1612f0 ("Fix
> rmmod/read/write races in /proc entries"), whether the entry has a
> ->proc_mmap or not. On NOMMU validate_mmap_request() takes that to mean
> the file can be mapped. procfs has no ->mmap_capabilities so a regular
> file gets NOMMU_MAP_COPY, and a private mapping never calls ->mmap at
> all. Instead do_mmap() takes nommu_region_sem for writing and
> do_mmap_private() reads the file into the copy with kernel_read().
>
> Reading /proc/maps takes nommu_region_sem as well:
>
> mmap(NULL, 4096, PROT_READ, MAP_PRIVATE, open("/proc/maps", O_RDONLY), 0)
>
> do_mmap() // down_write(&nommu_region_sem)
> -> do_mmap_private()
> -> kernel_read()
> [ ... ]
>
> Reported-by: Chris Mason <mason at kernel.org>
> Fixes: 786d7e1612f0 ("Fix rmmod/read/write races in /proc entries")
> Cc: stable at vger.kernel.org
> Signed-off-by: Christian Brauner (Amutable) <brauner at kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-work-procfs-bugfixes-v1-0-59422ed3e465@kernel.org?part=23
More information about the kexec
mailing list