[PATCH v2 4/4] kexec_file: Fix the issue of mismatch between loop variable types
Baoquan He
bhe at redhat.com
Tue Nov 4 19:05:44 PST 2025
On 11/03/25 at 02:34pm, Qiang Ma wrote:
> The type of the struct kimage member variable nr_segments is unsigned long.
> Correct the loop variable i and the print format specifier type.
I can't see what's meaningful with this change. nr_segments is unsigned
long, but it's the range 'i' will loop. If so, we need change all for
loop of the int iterator.
>
> Signed-off-by: Qiang Ma <maqianga at uniontech.com>
> ---
> kernel/kexec_file.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 4a24aadbad02..7afdaa0efc50 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -366,7 +366,8 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd,
> int image_type = (flags & KEXEC_FILE_ON_CRASH) ?
> KEXEC_TYPE_CRASH : KEXEC_TYPE_DEFAULT;
> struct kimage **dest_image, *image;
> - int ret = 0, i;
> + int ret = 0;
> + unsigned long i;
>
> /* We only trust the superuser with rebooting the system. */
> if (!kexec_load_permitted(image_type))
> @@ -432,7 +433,7 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd,
> struct kexec_segment *ksegment;
>
> ksegment = &image->segment[i];
> - kexec_dprintk("segment[%d]: buf=0x%p bufsz=0x%zx mem=0x%lx memsz=0x%zx\n",
> + kexec_dprintk("segment[%lu]: buf=0x%p bufsz=0x%zx mem=0x%lx memsz=0x%zx\n",
> i, ksegment->buf, ksegment->bufsz, ksegment->mem,
> ksegment->memsz);
>
> --
> 2.20.1
>
More information about the kexec
mailing list