[PATCH] makedumpfile: fix gcc-15 compiling error: too many arguments to function eppic_init

[YAMAZAKI MASAMITSU(山崎 真光)]

Hi Coiby,

Oops. I'm so sorry. I will correct any typos found next.

But, Thanks for finding this building error and fixing. 
When building makekdumpfile against gcc-14, not problem.
However, certainly could not build using gcc-15.　Thanks!

Best regards,
Masa

-----Original Message-----
From: kexec <kexec-bounces at lists.infradead.org> On Behalf Of Coiby Xu
Sent: Tuesday, February 11, 2025 4:18 PM
To: kexec at lists.infradead.org; Kazuhito Hagio <k-hagio at ab.jp.nec.com>
Subject: Re: [PATCH] makedumpfile: fix gcc-15 compiling error: too many arguments to function eppic_init

Hi Kazuhito,

In case you miss this patch because I forgot to prefix the email subject
with "makedumpfile".

On Thu, Jan 23, 2025 at 05:47:10PM +0800, Coiby Xu wrote:
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2340813
>
>When building makekdumpfile against gcc-15, the following error is
                ^^^^^^^^^^^^^
                makedumpfile
Oh, there is a typo. Please help me fix it if you are going to merge the
patch. Thanks!

>shown,
>
>    erase_info.c: In function ‘process_eppic_file’:
>    erase_info.c:2226:13: error: too many arguments to function ‘eppic_init’; expected 0, have 1
>     2226 |         if (eppic_init(&eppic_cb)) {
>          |             ^~~~~~~~~~ ~~~~~~~~~
>    make: *** [Makefile:109: erase_info.o] Error 1
>
>Signed-off-by: Coiby Xu <coxu at redhat.com>
>---
> erase_info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/erase_info.c b/erase_info.c
>index cbe1681..af6bfae 100644
>--- a/erase_info.c
>+++ b/erase_info.c
>@@ -2192,7 +2192,7 @@ process_eppic_file(char *name_config)
> {
> 	void *handle;
> 	void (*eppic_load)(char *), (*eppic_unload)(char *);
>-	int (*eppic_init)();
>+	int (*eppic_init)(struct call_back *);
>
> 	/*
> 	 * Dynamically load the eppic_makedumpfile.so library.
>-- 
>2.48.1
>

-- 
Best regards,
Coiby

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6613 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/kexec/attachments/20250218/e3acb782/attachment.p7s>