[RFC 1/7] efi/libstub: Ask efi_random_alloc() to skip unusable memory

Pingfan Liu piliu at redhat.com
Fri Jul 19 06:42:55 PDT 2024


On Fri, Jul 19, 2024 at 1:20 AM Jarkko Sakkinen <jarkko at kernel.org> wrote:
>
> On Thu, 2024-07-18 at 16:57 +0800, Pingfan Liu wrote:
> > efi_random_alloc() demands EFI_ALLOCATE_ADDRESS when allocate_pages(),
> > but the current implement can not ensure the selected target locates
> > inside free area, that is to exclude EFI_BOOT_SERVICES_*,
> > EFI_RUNTIME_SERVICES_* etc.
> >
> > Fix the issue by checking md->type.
> >
> > Signed-off-by: Pingfan Liu <piliu at redhat.com>
> > Cc: Ard Biesheuvel <ardb at kernel.org>
> > Cc: Jan Hendrik Farr <kernel at jfarr.cc>
> > Cc: Philipp Rudo <prudo at redhat.com>
> > Cc: Lennart Poettering <mzxreary at 0pointer.de>
> > Cc: Jarkko Sakkinen <jarkko at kernel.org>
> > Cc: Baoquan He <bhe at redhat.com>
> > Cc: Dave Young <dyoung at redhat.com>
> > Cc: Mark Rutland <mark.rutland at arm.com>
> > Cc: Will Deacon <will at kernel.org>
> > Cc: Catalin Marinas <catalin.marinas at arm.com>
> > To: linux-arm-kernel at lists.infradead.org
> > To: kexec at lists.infradead.org
> > To: linux-efi at vger.kernel.org
>
> I'm on holiday up until end of next week so not going to go this trough
> right now but I have minor complain ;-)
>
> Please use:
>
>        --[no-]cc-cover
>            If this is set, emails found in Cc: headers in the first patch of the series (typically
>            the cover letter) are added to the cc list for each email set. Default is the value of
>            sendemail.ccCover configuration value; if that is unspecified, default to --no-cc-cover.
>        [from "man git-send-email"]
>
> This will make the commits less bloated and makes sure that everyone you
> might want to CC will get always the same set of patches.
>
> I'd also recommend to pick only one list for to-field because there can
> be only one maintainer that in the end would take these patches. Change
> rest to cc's. Now the process of managing these patches is ambiguous by
> definition.
>

Sorry for the unnecessary noise, I will follow your suggestion in the
next round.

Thanks,

Pingfan

> BR, Jarkko
>
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>




More information about the kexec mailing list