[PATCH 1/2] makedumpfile: Add ftruncate error handling
HAGIO KAZUHITO(萩尾 一仁)
k-hagio-ab at nec.com
Wed Aug 21 23:25:19 PDT 2024
On 2024/08/21 16:30, Stefan Wiehler wrote:
>> I tried to reproduce those warnings, but could not get either one
>> with a plain make command and gcc 14.1 (or clang 18.1).
>>
>> out of curiosity, what compiler version and build command do you use?
>
> We use GCC 12.2.0 and build via the BitBake recipe:
>
> https://layers.openembedded.org/layerindex/recipe/52214/
>
> The recipe removes hardcoded CFLAGS in the Makefile, so it is not
> obvious to me right now if we get these error warnings due to additional
> CFLAGS we inject by default to each recipe or due to below patch alone:
>
> https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-kernel/makedumpfile/makedumpfile/0001-makedumpfile-replace-hardcode-CFLAGS.patch?h=master
Thanks for the reply.
I found that the 1/2 warning is reproduced with -D_FORTIFY_SOURCE. The 2/2
warning is still not reproduced, but the patches look good to me, so applied.
https://github.com/makedumpfile/makedumpfile/commit/3de748452194e9363042b27ae069c779059a12f7
https://github.com/makedumpfile/makedumpfile/commit/bd30437c629220d26824a8f1ef28b2e47e0529e5
Thanks,
Kazu
More information about the kexec
mailing list