[PATCH] fix comment: Mention current logic for vmalloc_start

Aditya Gupta adityag at linux.ibm.com
Thu Aug 1 00:22:27 PDT 2024


Previous comment is not valid anymore as for newer kernels we are
getting vmalloc_start from NUMBER(vmalloc_start)

The logic was changed in makedumpfile:
    commit 94241fd2feed ("[PATCH] ppc64: get vmalloc start address from vmcoreinfo")

Fix comment for better understanding.

Signed-off-by: Aditya Gupta <adityag at linux.ibm.com>

---
repository: makedumpfile

patch should apply on commit 900190de6b67b2de410cfc8023c1b198a416ceb3
---
---
 arch/ppc64.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/ppc64.c b/arch/ppc64.c
index a54f9a04db7f..8ad9d6e3265f 100644
--- a/arch/ppc64.c
+++ b/arch/ppc64.c
@@ -566,7 +566,9 @@ get_machdep_info_ppc64(void)
 	DEBUG_MSG("kernel_start : %lx\n", info->kernel_start);
 
 	/*
-	 * Get vmalloc_start value from either vmap_area_list or vmlist.
+	 * To get vmalloc_start, prefer NUMBER(vmalloc_start) if exported in
+	 * vmcoreinfo, as 'vmap_area_list' and 'vmlist' in Linux 6.9 and later
+	 * kernels might be empty
 	 */
 	if (NUMBER(vmalloc_start) != NOT_FOUND_NUMBER) {
 		vmalloc_start = NUMBER(vmalloc_start);
-- 
2.45.2




More information about the kexec mailing list