[PATCH 08/11] sysctl: Add size to register_sysctl_init
Joel Granados
j.granados at samsung.com
Wed Jun 21 06:15:52 PDT 2023
On Wed, Jun 21, 2023 at 12:47:58PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados wrote:
> > static int __init random_sysctls_init(void)
> > {
> > - register_sysctl_init("kernel/random", random_table);
> > + register_sysctl_init("kernel/random", random_table,
> > + ARRAY_SIZE(random_table));
>
> As mentioned before, why not just do:
>
> #define register_sysctl_init(string, table) \
> __register_sysctl_init(string, table, ARRAY_SIZE(table);
Answered you in the original mail where you suggested it.
Best
>
> or something like that?
>
> That way no callers need to change AND you prevent the size from ever
> being incorrect?
>
> thanks,
>
> greg k-h
--
Joel Granados
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/kexec/attachments/20230621/e8deb2bc/attachment-0001.sig>
More information about the kexec
mailing list