[PATCH] kexec_core: fix the assignment to kimage->control_page

Yuntao Wang ytcoode at gmail.com
Wed Dec 20 20:23:08 PST 2023


image->control_page represents the starting address for allocating the next
control page, while hole_end represents the address of the last valid byte
of the currently allocated control page.

Therefore, after successfully allocating a control page, image->control_page
should be updated to `hole_end + 1`, rather than hole_end.

Signed-off-by: Yuntao Wang <ytcoode at gmail.com>
---
 kernel/kexec_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 2f039a7d9af9..a08031b57a61 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -457,7 +457,7 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
 		/* If I don't overlap any segments I have found my hole! */
 		if (i == image->nr_segments) {
 			pages = pfn_to_page(hole_start >> PAGE_SHIFT);
-			image->control_page = hole_end;
+			image->control_page = hole_end + 1;
 			break;
 		}
 	}
-- 
2.43.0




More information about the kexec mailing list